Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 942493002: Clear Map::constructor to object_function from the same context for prototype maps. This avoids kee… (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clear Map::constructor to object_function from the same context for prototype maps. This avoids keeping small pockets of memory alive for the common pattern where prototypes are used to emulate classes: function inherit(parent, child) { function p() {} p.prototype = parent.prototype; child.prototype = new p(); } Otherwise child.prototype[constructor] keeps alive p, p's context, the initial map attached to p, and the (now empty) transition array of the initial map. BUG= Committed: https://crrev.com/e758a36b0255bba192d35cc14d2ffbedc019e029 Cr-Commit-Position: refs/heads/master@{#26747}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/objects.cc View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
LGTM with the comment updated as discussed offline.
5 years, 10 months ago (2015-02-19 12:18:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942493002/50001
5 years, 10 months ago (2015-02-19 12:24:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942493002/70001
5 years, 10 months ago (2015-02-19 12:28:48 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 10 months ago (2015-02-19 13:01:57 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 13:02:09 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e758a36b0255bba192d35cc14d2ffbedc019e029
Cr-Commit-Position: refs/heads/master@{#26747}

Powered by Google App Engine
This is Rietveld 408576698