Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 942463002: Fix crash when shutting down affiliated invalidation service provider (Closed)

Created:
5 years, 10 months ago by bartfab (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when shutting down affiliated invalidation service provider When the affiliated invalidation service provider, it should: 1) unregister itself as an observer of various objects 2) tell consumers to stop using the current invalidation service 3) destroy the device-global invalidation service, if any Steps 2 and 3 were swapped. This meant that if the device-global invalidation service happened to be in use, it would be destroyed without giving consumers a chance to remove their handlers from it. BUG=455504 TEST=None Committed: https://crrev.com/b316c7450061cca6f49e92dc356b05cf638f9d81 Cr-Commit-Position: refs/heads/master@{#317017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bartfab (slow)
Hi Philipp, Could you take a look?
5 years, 10 months ago (2015-02-19 08:15:28 UTC) #2
pneubeck (no reviews)
lgtm
5 years, 10 months ago (2015-02-19 08:37:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942463002/1
5 years, 10 months ago (2015-02-19 08:38:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 09:03:26 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 09:04:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b316c7450061cca6f49e92dc356b05cf638f9d81
Cr-Commit-Position: refs/heads/master@{#317017}

Powered by Google App Engine
This is Rietveld 408576698