Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 942413002: Port sky-drawer to Dart (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port sky-drawer to Dart Also, port the "appish" example to exercise the drawer. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6e8d6cbfc9926b9da91dac28270e583783cdbdc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -361 lines) Patch
D sky/examples/appish.sky View 1 chunk +0 lines, -26 lines 0 comments Download
A + sky/examples/appish/example-scaffold.sky View 3 chunks +17 lines, -12 lines 0 comments Download
A sky/examples/appish/index.sky View 1 chunk +12 lines, -0 lines 0 comments Download
D sky/examples/example-scaffold.sky View 1 chunk +0 lines, -79 lines 0 comments Download
A sky/framework/animation/controller.dart View 1 chunk +48 lines, -0 lines 0 comments Download
D sky/framework/animation/controller.sky View 1 chunk +0 lines, -46 lines 0 comments Download
A sky/framework/animation/curves.dart View 1 chunk +54 lines, -0 lines 0 comments Download
D sky/framework/animation/curves.sky View 1 chunk +0 lines, -55 lines 0 comments Download
A sky/framework/animation/timer.dart View 1 chunk +51 lines, -0 lines 0 comments Download
D sky/framework/animation/timer.sky View 1 chunk +0 lines, -49 lines 0 comments Download
M sky/framework/sky-drawer.sky View 2 chunks +95 lines, -94 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-23 04:36:26 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-23 16:03:21 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-23 16:31:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e8d6cbfc9926b9da91dac28270e583783cdbdc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698