Add a simple way of performing step by step tests for testers.

Add a simple way of performing step by step tests for testers.

To debug tests, they need to be executed with the following switches:
--remote-debugging-port=9222
--enable-file-manager-step-by-step-tests
--enable-pixel-output-in-tests
--ui-test-action-timeout=10000000

Then run http://localhost:9222 in a separate browser window, then select
"chrome manager browser tests" and follow instructions.

TEST=Tested manually.
BUG=460813
Committed: https://crrev.com/d31096d3f309ebfdd3f5fd8bd784d3caf2d54e91
Cr-Commit-Position: refs/heads/master@{#317559}

[mtomasz, 2015-02-23 06:43:44]

mtomasz@chromium.org changed reviewers:
+ hirono@chromium.org

[mtomasz, 2015-02-23 06:43:51]

@hirono: PTAL. Thanks.

[hirono, 2015-02-23 07:00:41]

Don't we need to add the switch to chromeos_switches.{h,cc}?

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
File ui/file_manager/integration_tests/remote_call.js (right):

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
ui/file_manager/integration_tests/remote_call.js:43: }).then(function() {
nit: We can receive stepByStepEnabled directly from isStepByStepEnabled, and can
return new Promise of #56 in this function so that #65 can refer
isStepByStepEnabled in this scope.

[mtomasz, 2015-02-23 09:30:43]

I don't think we need a flag. It's an internal one for our team use only. If we
added it, the constant wouldn't be referred even once in the code anyway. WDYT?

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
File ui/file_manager/integration_tests/remote_call.js (right):

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
ui/file_manager/integration_tests/remote_call.js:43: }).then(function() {
On 2015/02/23 07:00:40, hirono wrote:
> nit: We can receive stepByStepEnabled directly from isStepByStepEnabled, and
can
> return new Promise of #56 in this function so that #65 can refer
> isStepByStepEnabled in this scope.

I'm not sure if I understand. You mean to embed #56-#73 in a function passed to
isStepByStepEnabled().then()? That would increase indentations. How about now,
just passing "enabled" via promises to the second element of the chain? WDYT?

[hirono, 2015-02-23 10:01:10]

LGTM

> I don't think we need a flag. It's an internal one for our team use only. If
we
> added it, the constant wouldn't be referred even once in the code anyway.
WDYT?

So how about renaming it enable-file-manager-step-by-step-tests or something
like this? enable-step-by-step-tests sounds general, and we may have the same or
similar flag in the future.

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
File ui/file_manager/integration_tests/remote_call.js (right):

https://codereview.chromium.org/942393002/diff/40001/ui/file_manager/integrat...
ui/file_manager/integration_tests/remote_call.js:43: }).then(function() {
On 2015/02/23 09:30:43, mtomasz wrote:
> On 2015/02/23 07:00:40, hirono wrote:
> > nit: We can receive stepByStepEnabled directly from isStepByStepEnabled, and
> can
> > return new Promise of #56 in this function so that #65 can refer
> > isStepByStepEnabled in this scope.
> 
> I'm not sure if I understand. You mean to embed #56-#73 in a function passed
to
> isStepByStepEnabled().then()? That would increase indentations. How about now,
> just passing "enabled" via promises to the second element of the chain? WDYT?

SGTM!

[mtomasz, 2015-02-23 10:08:23]

New patchsets have been uploaded after l-g-t-m from hirono@chromium.org

[mtomasz, 2015-02-23 10:08:40]

Done. Thanks!

[mtomasz, 2015-02-23 10:08:44]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:09:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942393002/80001

[commit-bot: I haz the power, 2015-02-23 10:27:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-23 10:28:41]

Patchset 5 (id:??) landed as
https://crrev.com/d31096d3f309ebfdd3f5fd8bd784d3caf2d54e91
Cr-Commit-Position: refs/heads/master@{#317559}