Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Issue 942313002: Web MIDI: change permission description (Closed)

Created:
5 years, 10 months ago by Takashi Toyoshima
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: change permission description Change some permission descriptions from MIDI to MIDI devices. BUG=453680 NOTRY=true Committed: https://crrev.com/e8e88dadc0cdf7c8b1c510c171f5ad20b22b9980 Cr-Commit-Position: refs/heads/master@{#317549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Takashi Toyoshima
Hi Kenji-san, Can you double check this Web MIDI permission related description updates.
5 years, 10 months ago (2015-02-21 20:42:02 UTC) #2
kenjibaheux
lgtm
5 years, 10 months ago (2015-02-23 05:22:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942313002/1
5 years, 10 months ago (2015-02-23 05:34:37 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-23 05:34:40 UTC) #7
kouhei (in TOK)
rubberstamp lgtm
5 years, 10 months ago (2015-02-23 06:05:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942313002/1
5 years, 10 months ago (2015-02-23 06:07:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61488)
5 years, 10 months ago (2015-02-23 06:10:09 UTC) #13
Takashi Toyoshima
NOTRY=true because this is just a mechanical string change.
5 years, 10 months ago (2015-02-23 06:12:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942313002/1
5 years, 10 months ago (2015-02-23 06:12:52 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 06:13:17 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 06:13:46 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8e88dadc0cdf7c8b1c510c171f5ad20b22b9980
Cr-Commit-Position: refs/heads/master@{#317549}

Powered by Google App Engine
This is Rietveld 408576698