Issue 942243002: Web MIDI: blink API update to support MIDIPortState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942243002: Web MIDI: blink API update to support MIDIPortState (Closed)

Created:
5 years, 10 months ago by Takashi Toyoshima

Modified:
5 years, 10 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Web MIDI: blink API update to support MIDIPortState The latest editor's draft introduces MIDIPortState state attribute in MIDIPort. To support the attribute, update the blink API to use enum for representing MIDIPortState instead of bool isActive flag. Spec: http://webaudio.github.io/web-midi-api/#idl-def-MIDIPort This is the first step of three to update the MIDIAccessor blink API. BUG=279097 TEST=build with chromium Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190630

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -0 lines)			Patch
M	Source/modules/webmidi/MIDIAccessor.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/modules/webmidi/MIDIAccessor.cpp	View	3 chunks	+22 lines, -0 lines	0 comments	Download
M	public/platform/WebMIDIAccessorClient.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942243002/1

5 years, 10 months ago (2015-02-22 23:36:56 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 00:51:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190630

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages