Source/modules/accessibility/AXTableColumn.h - Issue 942183003: Remove some redundant code from accessibility table headers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/accessibility/AXTableColumn.h

Issue 942183003: Remove some redundant code from accessibility table headers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 virtual void addChildren() override;	59 virtual void addChildren() override;

60 virtual void setParent(AXObject*) override;	60 virtual void setParent(AXObject*) override;

61	61

62 virtual LayoutRect elementRect() const override;	62 virtual LayoutRect elementRect() const override;

63	63

64 private:	64 private:

65 unsigned m_columnIndex;	65 unsigned m_columnIndex;

66 LayoutRect m_columnRect;	66 LayoutRect m_columnRect;

67	67

68 virtual bool isTableCol() const override { return true; }	68 virtual bool isTableCol() const override { return true; }

69 AXObject* headerObjectForSection(LayoutTableSection*, bool thTagRequired);

70 virtual bool computeAccessibilityIsIgnored() const override;	69 virtual bool computeAccessibilityIsIgnored() const override;

71 };	70 };

72	71

73 DEFINE_AX_OBJECT_TYPE_CASTS(AXTableColumn, isTableCol());	72 DEFINE_AX_OBJECT_TYPE_CASTS(AXTableColumn, isTableCol());

74	73

75 } // namespace blink	74 } // namespace blink

76	75

77 #endif // AXTableColumn_h	76 #endif // AXTableColumn_h

OLD	NEW

« no previous file with comments | « Source/modules/accessibility/AXARIAGridRow.cpp ('k') | Source/modules/accessibility/AXTableColumn.cpp » ('j') | no next file with comments »