Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 942183003: Remove some redundant code from accessibility table headers (Closed)

Created:
5 years, 10 months ago by k.czech
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove some redundant code from accessibility table headers headerObject() and headerObjectsForRow/Column methods look very similar. They do almost exactly the same thing. It looks like some bits could be shared among them. There would also be less code to maintain. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -118 lines) Patch
M Source/modules/accessibility/AXARIAGridRow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXARIAGridRow.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/modules/accessibility/AXTableColumn.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXTableColumn.cpp View 2 chunks +8 lines, -84 lines 0 comments Download
M Source/modules/accessibility/AXTableRow.cpp View 1 chunk +4 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
k.czech
5 years, 10 months ago (2015-02-23 23:11:48 UTC) #2
k.czech
On 2015/02/23 23:11:48, k.czech wrote: I also wanted to make sure that I did not ...
5 years, 10 months ago (2015-02-24 12:15:20 UTC) #3
dmazzoni
lgtm Thanks for the cleanup!
5 years, 10 months ago (2015-02-24 16:33:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942183003/1
5 years, 10 months ago (2015-02-24 16:34:05 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 17:31:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190761

Powered by Google App Engine
This is Rietveld 408576698