extensions/renderer/resources/guest_view/web_view.js - Issue 942183002: Speculative fix for executeScript bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view.js

Issue 942183002: Speculative fix for executeScript bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/guest_view/web_view.js

diff --git a/extensions/renderer/resources/guest_view/web_view.js b/extensions/renderer/resources/guest_view/web_view.js

index 32f99f1ac59789a9a57203a4f8e2dd6431c89ea2..e16555d5483a9fe4368747c6c9473805ac7ecf06 100644

--- a/extensions/renderer/resources/guest_view/web_view.js

+++ b/extensions/renderer/resources/guest_view/web_view.js

@@ -241,7 +241,7 @@ WebViewImpl.prototype.executeCode = function(func, args) {

}

var webviewSrc = this.attributes[WebViewConstants.ATTRIBUTE_SRC].getValue();

- if (this.baseUrlForDataUrl != '') {

+ if (this.baseUrlForDataUrl) {

webviewSrc = this.baseUrlForDataUrl;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »