Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 942153004: Web MIDI: Add MIDIPortState state attribute to MIDIPort (Closed)

Created:
5 years, 10 months ago by Takashi Toyoshima
Modified:
5 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Web MIDI: Add MIDIPortState state attribute to MIDIPort Now the latest editor's draft has MIDIPortState state attribute in MIDIPort. http://webaudio.github.io/web-midi-api/#midiport-interface BUG=279097 TEST=LayoutTest/webmidi Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M LayoutTests/webmidi/requestmidiaccess.html View 2 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/webmidi/requestmidiaccess-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/webmidi/MIDIPort.idl View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Takashi Toyoshima
Hi, can you take a look?
5 years, 10 months ago (2015-02-21 12:36:48 UTC) #2
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-21 23:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942153004/1
5 years, 10 months ago (2015-02-21 23:18:31 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-22 00:35:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190620

Powered by Google App Engine
This is Rietveld 408576698