Adding synthetic touch/mouse drag [Part2]

content/common/input/input_param_traits.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/input/input_param_traits.h"
 
 #include "content/common/content_param_traits.h"
 #include "content/common/input/synthetic_pinch_gesture_params.h"
+#include "content/common/input/synthetic_smooth_drag_gesture_params.h"
 #include "content/common/input/synthetic_smooth_scroll_gesture_params.h"
 #include "content/common/input/web_input_event_traits.h"
 #include "content/common/input_messages.h"
 
 namespace IPC {
 namespace {
 template<typename GestureType>
 scoped_ptr<content::SyntheticGestureParams> ReadGestureParams(
     const Message* m,
     PickleIterator* iter)
@@ skipping 36 matching lines @@
 
 void ParamTraits<content::SyntheticGesturePacket>::Write(Message* m,
                                                          const param_type& p) {
   DCHECK(p.gesture_params());
   WriteParam(m, p.gesture_params()->GetGestureType());
   switch (p.gesture_params()->GetGestureType()) {
     case content::SyntheticGestureParams::SMOOTH_SCROLL_GESTURE:
       WriteParam(m, *content::SyntheticSmoothScrollGestureParams::Cast(
           p.gesture_params()));
       break;
+    case content::SyntheticGestureParams::SMOOTH_DRAG_GESTURE:
+      WriteParam(m, *content::SyntheticSmoothDragGestureParams::Cast(
+                        p.gesture_params()));

[petrcermak, 2015/02/20 18:00:32]

This line shouldn't be indented so much (look at the other cases below).

+      break;
     case content::SyntheticGestureParams::PINCH_GESTURE:
       WriteParam(m, *content::SyntheticPinchGestureParams::Cast(
           p.gesture_params()));
       break;
     case content::SyntheticGestureParams::TAP_GESTURE:
       WriteParam(m, *content::SyntheticTapGestureParams::Cast(
           p.gesture_params()));
       break;
-    // TODO(ssid): When API and IPC messages are set up, implement this.
-    case content::SyntheticGestureParams::SMOOTH_DRAG_GESTURE:
-      NOTIMPLEMENTED();
-      break;
   }
 }
 
 bool ParamTraits<content::SyntheticGesturePacket>::Read(const Message* m,
                                                         PickleIterator* iter,
                                                         param_type* p) {
   content::SyntheticGestureParams::GestureType gesture_type;
   if (!ReadParam(m, iter, &gesture_type))
     return false;
   scoped_ptr<content::SyntheticGestureParams> gesture_params;
   switch (gesture_type) {
     case content::SyntheticGestureParams::SMOOTH_SCROLL_GESTURE:
       gesture_params =
           ReadGestureParams<content::SyntheticSmoothScrollGestureParams>(m,
                                                                          iter);
       break;
+    case content::SyntheticGestureParams::SMOOTH_DRAG_GESTURE:
+      gesture_params =
+          ReadGestureParams<content::SyntheticSmoothDragGestureParams>(m, iter);
+      break;
     case content::SyntheticGestureParams::PINCH_GESTURE:
       gesture_params =
           ReadGestureParams<content::SyntheticPinchGestureParams>(m, iter);
       break;
     case content::SyntheticGestureParams::TAP_GESTURE:
       gesture_params =
           ReadGestureParams<content::SyntheticTapGestureParams>(m, iter);
       break;
     default:
       return false;
   }
 
   p->set_gesture_params(gesture_params.Pass());
   return p->gesture_params() != NULL;
 }
 
 void ParamTraits<content::SyntheticGesturePacket>::Log(const param_type& p,
                                                        std::string* l) {
   DCHECK(p.gesture_params());
   switch (p.gesture_params()->GetGestureType()) {
     case content::SyntheticGestureParams::SMOOTH_SCROLL_GESTURE:
       LogParam(
           *content::SyntheticSmoothScrollGestureParams::Cast(
               p.gesture_params()),
           l);
       break;
+    case content::SyntheticGestureParams::SMOOTH_DRAG_GESTURE:
+      LogParam(
+          *content::SyntheticSmoothDragGestureParams::Cast(p.gesture_params()),
+          l);
+      break;
     case content::SyntheticGestureParams::PINCH_GESTURE:
       LogParam(
           *content::SyntheticPinchGestureParams::Cast(p.gesture_params()),
           l);
       break;
     case content::SyntheticGestureParams::TAP_GESTURE:
       LogParam(
           *content::SyntheticTapGestureParams::Cast(p.gesture_params()),
           l);
       break;
-    // TODO(ssid): When API and IPC messages are set up, implement this.
-    case content::SyntheticGestureParams::SMOOTH_DRAG_GESTURE:
-      NOTIMPLEMENTED();
-      break;
   }
 }
 
 }  // namespace IPC