Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 942123002: MIPS: Fix label position types in binding code. (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix label position types in binding code. Also some target_at and target_at_put uniformed on mips and mips64. BUG= Committed: https://crrev.com/39f58c2451e087dcdece0916d750ae5719483234 Cr-Commit-Position: refs/heads/master@{#26785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 8 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-02-20 16:14:29 UTC) #2
dusmil.imgtec
lgtm.
5 years, 10 months ago (2015-02-20 17:09:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942123002/1
5 years, 10 months ago (2015-02-20 19:04:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:29:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:29:36 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:30:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39f58c2451e087dcdece0916d750ae5719483234
Cr-Commit-Position: refs/heads/master@{#26785}

Powered by Google App Engine
This is Rietveld 408576698