Issue 942103004: Validate debuggee.targetId before use in chrome.debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 942103004: Validate debuggee.targetId before use in chrome.debugger (Closed)

Created:
5 years, 10 months ago by robwu

Modified:
5 years, 10 months ago

Reviewers:
Devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

More Reviews

Description

Validate debuggee.targetId before use in chrome.debugger And refactored the tests to make sure that the debugger is detached upon returning from RunAttachFunction. Previously, if the debugger unexpectedly succeeded in attaching, the method would return (because empty error != some error), causing the attached debugger to not be detached. R=rdevlin.cronin@chromium.org BUG=456841 TEST=browser_tests DebuggerApiTest.DebuggerNotAllowedOnOtherExtensionPages Review URL: https://codereview.chromium.org/910053002 Cr-Commit-Position: refs/heads/master@{#315675} (cherry picked from commit 409bf9d6104f83c80cd85bd261784b39cab8e93e) Committed: https://chromium.googlesource.com/chromium/src/+/9768ebe3814ebf553851a5005620c048d5f1e1c6

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -21 lines)			Patch
	M	chrome/browser/extensions/api/debugger/debugger_api.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/extensions/api/debugger/debugger_apitest.cc	View		2 chunks	+58 lines, -21 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

robwu

5 years, 10 months ago (2015-02-20 16:32:37 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9768ebe3814ebf553851a5005620c048d5f1e1c6.

Expand Messages | Collapse Messages