Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java

Issue 942103003: Handle notification preferences intent from gear icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
index 83a658ca76dd597190a7597bf4bcab80aae5303a..a484c8f6ef6dc446ec307a8df19c5027fd3a09a0 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java
@@ -5,9 +5,7 @@
package org.chromium.chrome.browser.preferences;
import android.app.Activity;
-import android.app.Fragment;
import android.app.Instrumentation;
-import android.app.Notification;
import android.content.Context;
import android.content.Intent;
import android.preference.Preference;
@@ -18,7 +16,6 @@
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.chrome.browser.accessibility.FontSizePrefs;
-import org.chromium.chrome.browser.preferences.website.WebsitePreferences;
import org.chromium.chrome.browser.search_engines.TemplateUrlService;
import org.chromium.chrome.browser.search_engines.TemplateUrlService.LoadListener;
import org.chromium.chrome.shell.ChromeShellTestBase;
@@ -125,25 +122,8 @@ public void run() {
});
}
- /**
- * Starts the preference activity as if it's been opened from the App Notification settings
- * screen to verify that it opens the Notifications Site Settings screen.
- */
- @SmallTest
- @Feature({"Preferences"})
- public void testNotificationSettingsCategoryIntent() throws Exception {
- Instrumentation instrumentation = getInstrumentation();
-
- Intent intent = PreferencesLauncher.createIntentForSettingsPage(
- instrumentation.getTargetContext(), null);
- intent.addCategory(Notification.INTENT_CATEGORY_NOTIFICATION_PREFERENCES);
-
- Activity activity = instrumentation.startActivitySync(intent);
- assertTrue(activity instanceof Preferences);
-
- Fragment fragment = ((Preferences) activity).getFragmentForTest();
- assertTrue(fragment instanceof WebsitePreferences);
- }
+ // TODO(mvanouwerkerk): Write new preference intent tests for notification settings.
+ // https://crbug.com/461885
/**
* Tests setting FontScaleFactor and ForceEnableZoom in AccessibilityPreferences and ensures

Powered by Google App Engine
This is Rietveld 408576698