Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 942083004: Use IDWriteFontFallback when available. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use IDWriteFontFallback when available. This is prefereable to the current IDWriteTextLayout method, but is only available on Windows 8.1 and later. Committed: https://skia.googlesource.com/skia/+/28512f7f54bf9783e9ee1c93ae0403ac1c0963b9

Patch Set 1 #

Patch Set 2 : Cache the query. #

Total comments: 2

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -8 lines) Patch
M src/ports/SkFontMgr_win_dw.cpp View 1 2 8 chunks +160 lines, -8 lines 0 comments Download
M src/utils/win/SkDWrite.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bungeman-skia
This is the interface I think one is 'supposed' to use. However, it's only available ...
5 years, 10 months ago (2015-02-23 17:00:29 UTC) #2
mtklein
lgtm https://codereview.chromium.org/942083004/diff/20001/src/ports/SkFontMgr_win_dw.cpp File src/ports/SkFontMgr_win_dw.cpp (right): https://codereview.chromium.org/942083004/diff/20001/src/ports/SkFontMgr_win_dw.cpp#newcode812 src/ports/SkFontMgr_win_dw.cpp:812: return createTypefaceFromDWriteFont(fontFace.get(), mappedFont.get(), fontFamily.get()); this->
5 years, 10 months ago (2015-02-23 17:11:21 UTC) #3
bungeman-skia
https://codereview.chromium.org/942083004/diff/20001/src/ports/SkFontMgr_win_dw.cpp File src/ports/SkFontMgr_win_dw.cpp (right): https://codereview.chromium.org/942083004/diff/20001/src/ports/SkFontMgr_win_dw.cpp#newcode812 src/ports/SkFontMgr_win_dw.cpp:812: return createTypefaceFromDWriteFont(fontFace.get(), mappedFont.get(), fontFamily.get()); On 2015/02/23 17:11:21, mtklein wrote: ...
5 years, 10 months ago (2015-02-23 17:30:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942083004/40001
5 years, 10 months ago (2015-02-23 17:31:19 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/28512f7f54bf9783e9ee1c93ae0403ac1c0963b9
5 years, 10 months ago (2015-02-23 17:41:46 UTC) #8
bungeman-skia
5 years, 10 months ago (2015-02-23 18:08:19 UTC) #9
Message was sent while issue was closed. 
On 2015/02/23 17:41:46, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001) as
> https://skia.googlesource.com/skia/+/28512f7f54bf9783e9ee1c93ae0403ac1c0963b9

Followed up with https://codereview.chromium.org/943233004/ .

Powered by Google App Engine
This is Rietveld 408576698