Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 942023002: ZoomController: manual mode SetZoom() should early-out. (Closed)

Created:
5 years, 10 months ago by wjmaclean
Modified:
5 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ZoomController: manual mode SetZoom() should early-out. When used in manual mode, SetZoom() should early-out if the new zoom level is the same as the old one in order to avoid sending unnecessary ZoomChangedEvents. BUG=459995 Committed: https://crrev.com/bb26a8180d84b8c156005ef515f23f0308e42aae Cr-Commit-Position: refs/heads/master@{#317323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/ui/zoom/zoom_controller.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
fsamuel@ - tiny CL, please take a quick look?
5 years, 10 months ago (2015-02-20 13:58:04 UTC) #2
Fady Samuel
lgtm
5 years, 10 months ago (2015-02-20 14:12:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942023002/1
5 years, 10 months ago (2015-02-20 14:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:29:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:30:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb26a8180d84b8c156005ef515f23f0308e42aae
Cr-Commit-Position: refs/heads/master@{#317323}

Powered by Google App Engine
This is Rietveld 408576698