Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 942013006: Simplify scroll APIs in Element (Closed)

Created:
5 years, 10 months ago by rwlbuis
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify scroll APIs in Element - no need for virtual scrollTo/scrollBy. - bindings don't need extra scroll methods, we can just reuse scrollTo using ImplementedAs. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/core/dom/Element.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
5 years, 10 months ago (2015-02-24 21:34:32 UTC) #2
adamk
lgtm
5 years, 10 months ago (2015-02-24 22:15:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942013006/1
5 years, 10 months ago (2015-02-24 22:25:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_rel/builds/29421)
5 years, 10 months ago (2015-02-24 22:42:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942013006/1
5 years, 10 months ago (2015-02-24 23:11:47 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 01:26:56 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190787

Powered by Google App Engine
This is Rietveld 408576698