build_tools/common.sh - Issue 942013005: Enable building for ARM with nacl-clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_tools/common.sh

Issue 942013005: Enable building for ARM with nacl-clang (Closed) Base URL: https://chromium.googlesource.com/external/naclports.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build_tools/common.sh

diff --git a/build_tools/common.sh b/build_tools/common.sh

index c8cd452640a88c0fc37ef5637a526c1e45eb6dd8..310c5844e22d5ca876f2924e5de43b01e1fce4b9 100644

--- a/build_tools/common.sh

+++ b/build_tools/common.sh

@@ -66,7 +66,7 @@ NACLPORTS_LDFLAGS+=" -L${NACLPORTS_LIBDIR} -Wl,-rpath-link=${NACLPORTS_LIBDIR}"

# The NaCl version of ARM gcc emits warnings about va_args that

# are not particularly useful

-if [ "${NACL_ARCH}" = "arm" ]; then

+if [ "${NACL_ARCH}" = "arm" -a "${TOOLCHAIN}" = "newlib" ]; then

NACLPORTS_CFLAGS="${NACLPORTS_CFLAGS} -Wno-psabi"

NACLPORTS_CXXFLAGS="${NACLPORTS_CXXFLAGS} -Wno-psabi"

« no previous file with comments | « build_tools/buildbot_common.sh ('k') | ports/binutils/pkg_info » ('j') | no next file with comments »