Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 942013003: Python handler: Pass a python object to content handled application. (Closed)

Created:
5 years, 10 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Python handler: Pass a python object to content handled application. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bf69186ecdadfa8da605849e2c2f75adcdc8e262

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -23 lines) Patch
M mojo/public/python/mojo_application/application_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/python/src/common.h View 1 chunk +4 lines, -3 lines 2 comments Download
M mojo/public/python/src/common.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 7 chunks +28 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qsr
5 years, 10 months ago (2015-02-20 14:20:17 UTC) #1
qsr
gentle ping?
5 years, 10 months ago (2015-02-24 09:14:03 UTC) #2
etiennej
https://codereview.chromium.org/942013003/diff/1/services/python/content_handler/content_handler_main.cc File services/python/content_handler/content_handler_main.cc (right): https://codereview.chromium.org/942013003/diff/1/services/python/content_handler/content_handler_main.cc#newcode189 services/python/content_handler/content_handler_main.cc:189: ScopedPyRef py_input = Eval(handle_command, d); Why can't you use ...
5 years, 10 months ago (2015-02-24 09:20:55 UTC) #3
qsr
https://codereview.chromium.org/942013003/diff/1/services/python/content_handler/content_handler_main.cc File services/python/content_handler/content_handler_main.cc (right): https://codereview.chromium.org/942013003/diff/1/services/python/content_handler/content_handler_main.cc#newcode189 services/python/content_handler/content_handler_main.cc:189: ScopedPyRef py_input = Eval(handle_command, d); On 2015/02/24 09:20:54, etiennej ...
5 years, 10 months ago (2015-02-24 13:25:16 UTC) #4
etiennej
lgtm https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/common.h File mojo/public/python/src/common.h (right): https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/common.h#newcode40 mojo/public/python/src/common.h:40: ScopedPyRef(const ScopedPyRef& other); Then, unless I am missing ...
5 years, 10 months ago (2015-02-24 13:30:24 UTC) #5
qsr
https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/common.h File mojo/public/python/src/common.h (right): https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/common.h#newcode40 mojo/public/python/src/common.h:40: ScopedPyRef(const ScopedPyRef& other); On 2015/02/24 13:30:23, etiennej wrote: > ...
5 years, 10 months ago (2015-02-24 13:32:14 UTC) #6
qsr
5 years, 10 months ago (2015-02-24 13:32:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bf69186ecdadfa8da605849e2c2f75adcdc8e262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698