Python handler: Pass a python object to content handled application.

Python handler: Pass a python object to content handled application.

R=etiennej@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/bf69186ecdadfa8da605849e2c2f75adcdc8e262

[qsr, 2015-02-24 09:14:03]

gentle ping?

[etiennej, 2015-02-24 09:20:55]

https://codereview.chromium.org/942013003/diff/1/services/python/content_hand...
File services/python/content_handler/content_handler_main.cc (right):

https://codereview.chromium.org/942013003/diff/1/services/python/content_hand...
services/python/content_handler/content_handler_main.cc:189: ScopedPyRef
py_input = Eval(handle_command, d);
Why can't you use ScopedPyRef py_input(Eval(handle_command, d)); ?

[qsr, 2015-02-24 13:25:16]

https://codereview.chromium.org/942013003/diff/1/services/python/content_hand...
File services/python/content_handler/content_handler_main.cc (right):

https://codereview.chromium.org/942013003/diff/1/services/python/content_hand...
services/python/content_handler/content_handler_main.cc:189: ScopedPyRef
py_input = Eval(handle_command, d);
On 2015/02/24 09:20:54, etiennej wrote:
> Why can't you use ScopedPyRef py_input(Eval(handle_command, d)); ?

 I can. Done.

[etiennej, 2015-02-24 13:30:24]

lgtm

https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/c...
File mojo/public/python/src/common.h (right):

https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/c...
mojo/public/python/src/common.h:40: ScopedPyRef(const ScopedPyRef& other);
Then, unless I am missing something, you don't need that anymore. Same thing for
operator=.

[qsr, 2015-02-24 13:32:14]

https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/c...
File mojo/public/python/src/common.h (right):

https://codereview.chromium.org/942013003/diff/20001/mojo/public/python/src/c...
mojo/public/python/src/common.h:40: ScopedPyRef(const ScopedPyRef& other);
On 2015/02/24 13:30:23, etiennej wrote:
> Then, unless I am missing something, you don't need that anymore. Same thing
for
> operator=.

 As discussed offline, I do, as the return value for my method is a ScopedPyRef,
and the default constructor do not take a reference.

 Also, those 2 methods should have been there since the beginning, since this is
a scoped object over a refcounted python object, so it makes sense to be able to
copy it.

[qsr, 2015-02-24 13:32:23]

Committed patchset #2 (id:20001) manually as
bf69186ecdadfa8da605849e2c2f75adcdc8e262 (presubmit successful).