Reland the ULONG -> SIZE_T change from 317177

Reland the ULONG -> SIZE_T change from 317177

Testing shows that this change is correct, but there was no evidence supporting the other change. Will manually run the x64 dbg test try bot for this change.

TBR=thakis@chromium.org,jvoung@chromium.org
BUG=458690, 460563
Committed: https://crrev.com/266720b3da80e4be6b5feef669d0108fea5eded1
Cr-Commit-Position: refs/heads/master@{#318160}

[Nico, 2015-02-21 00:02:47]

lgtm; add BUG=460563

[jvoung (off chromium), 2015-02-21 00:03:50]

FWIW, I think it was the 32-bit chrome on 64-bit windows debug build that I used
to repro the bug.

[Reid Kleckner, 2015-02-21 00:06:14]

On 2015/02/21 00:03:50, jvoung wrote:
> FWIW, I think it was the 32-bit chrome on 64-bit windows debug build that I
used
> to repro the bug.

That should be covered by win_chromium_dbg_ng, based on its output so far. It's
not in the default try set because it's slow. I also threw in the x64 ones for
good measure.

[jvoung (off chromium), 2015-02-21 00:31:30]

On 2015/02/21 00:06:14, Reid Kleckner wrote:
> On 2015/02/21 00:03:50, jvoung wrote:
> > FWIW, I think it was the 32-bit chrome on 64-bit windows debug build that I
> used
> > to repro the bug.
> 
> That should be covered by win_chromium_dbg_ng, based on its output so far.
It's
> not in the default try set because it's slow. I also threw in the x64 ones for
> good measure.

Okay thanks for checking. I just wanted to make sure that's covered because the
CL description only mentioned "x64 dbg", and I wasn't sure what changed between
this CL and the previous one.

rs LGTM if the bots are green.

[Reid Kleckner, 2015-02-21 02:28:30]

Looks like this change is bad. =/

Guess I get to do some more low-level debugging.

[Reid Kleckner, 2015-02-24 22:33:38]

On 2015/02/21 02:28:30, Reid Kleckner wrote:
> Looks like this change is bad. =/
> 
> Guess I get to do some more low-level debugging.

Further debugging shows that this change should *not* be bad. The outparam is
definitely a SIZE_T, not a ULONG.

[Nico, 2015-02-24 23:26:06]

On Tue, Feb 24, 2015 at 2:33 PM, <rnk@chromium.org> wrote:

> On 2015/02/21 02:28:30, Reid Kleckner wrote:
>
>> Looks like this change is bad. =/
>>
>
>  Guess I get to do some more low-level debugging.
>>
>
> Further debugging shows that this change should *not* be bad. The outparam
> is
> definitely a SIZE_T, not a ULONG.
>

Maybe it's different on different Windows versions? I think the failing
tests were only seen on win7 boxen.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-02-25 00:20:20]

On Tue, Feb 24, 2015 at 3:26 PM, Nico Weber <thakis@chromium.org> wrote:

> On Tue, Feb 24, 2015 at 2:33 PM, <rnk@chromium.org> wrote:
>
>> On 2015/02/21 02:28:30, Reid Kleckner wrote:
>>
>>> Looks like this change is bad. =/
>>>
>>
>>  Guess I get to do some more low-level debugging.
>>>
>>
>> Further debugging shows that this change should *not* be bad. The
>> outparam is
>> definitely a SIZE_T, not a ULONG.
>>
>
> Maybe it's different on different Windows versions? I think the failing
> tests were only seen on win7 boxen.
>

We're testing on Win7, though. =/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Reid Kleckner, 2015-02-25 23:30:12]

Those Win dbg x64 failures look like they are present without this patch, so I
think this is good.

[Reid Kleckner, 2015-02-25 23:30:17]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2015-02-25 23:31:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942003008/1

[commit-bot: I haz the power, 2015-02-26 00:41:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-26 00:42:07]

Patchset 1 (id:??) landed as
https://crrev.com/266720b3da80e4be6b5feef669d0108fea5eded1
Cr-Commit-Position: refs/heads/master@{#318160}

[Reid Kleckner, 2015-02-26 00:42:55]

This is the bot that went red previously:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

I'll keep an eye on it.

[Nico, 2015-02-26 00:44:38]

maybe give the sheriffs a heads-up on irc

On Wed, Feb 25, 2015 at 4:42 PM, <rnk@chromium.org> wrote:

> This is the bot that went red previously:
> http://build.chromium.org/p/chromium.win/builders/Win7%
> 20Tests%20%28dbg%29%281%29/
>
> I'll keep an eye on it.
>
> https://codereview.chromium.org/942003008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.