Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 942003003: Add v8::Object::GetRealNamedPropertyAttributes() (Closed)

Created:
5 years, 10 months ago by bnoordhuis
Modified:
5 years, 10 months ago
Reviewers:
Yang, Toon Verwaest
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add v8::Object::GetRealNamedPropertyAttributes() Add v8::Object::GetRealNamedPropertyAttributes() and v8::Object::GetRealNamedPropertyAttributesInPrototypeChain(). See https://github.com/iojs/io.js/issues/864 for background. Committed: https://crrev.com/726eb0582b23bc90f4acd496ebb6a08be1d8f3ac Cr-Commit-Position: refs/heads/master@{#26855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M include/v8.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/api.cc View 3 chunks +40 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
bnoordhuis
Yang, I'm sorry to keep picking you as a reviewer but according to `git shortlog ...
5 years, 10 months ago (2015-02-20 14:00:38 UTC) #2
Yang
Toon, what do you think?
5 years, 10 months ago (2015-02-20 14:05:14 UTC) #4
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-25 14:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942003003/1
5 years, 10 months ago (2015-02-25 14:41:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 15:09:17 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:09:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/726eb0582b23bc90f4acd496ebb6a08be1d8f3ac
Cr-Commit-Position: refs/heads/master@{#26855}

Powered by Google App Engine
This is Rietveld 408576698