Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 942003002: Fix GC-unsafe use of BreakLocationIterator. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GC-unsafe use of BreakLocationIterator. R=svenpanne@chromium.org BUG=v8:3776 LOG=N Committed: https://crrev.com/0aa1d2af3744d8ace96308082c80a12cd2e55d4c Cr-Commit-Position: refs/heads/master@{#26779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -84 lines) Patch
M src/debug.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/debug.cc View 4 chunks +57 lines, -77 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 10 months ago (2015-02-20 13:31:18 UTC) #1
Sven Panne
lgtm
5 years, 10 months ago (2015-02-20 13:55:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942003002/1
5 years, 10 months ago (2015-02-20 13:57:09 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-20 14:47:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 14:47:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:47:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0aa1d2af3744d8ace96308082c80a12cd2e55d4c
Cr-Commit-Position: refs/heads/master@{#26779}

Powered by Google App Engine
This is Rietveld 408576698