Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 941993002: Add missing test for CollectControlProjections on calls. (Closed)

Created:
5 years, 10 months ago by Michael Starzinger
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_trycatch-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing test for CollectControlProjections on calls. R=bmeurer@chromium.org TEST=unittests/NodePropertiesTest.CollectControlProjections_Call Committed: https://crrev.com/7dba829be9b12b85e63919ccd7d20656246647fa Cr-Commit-Position: refs/heads/master@{#26777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M test/unittests/compiler/node-properties-unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 10 months ago (2015-02-20 10:26:19 UTC) #1
Benedikt Meurer
lgtm
5 years, 10 months ago (2015-02-20 12:07:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941993002/1
5 years, 10 months ago (2015-02-20 13:00:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 14:05:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 14:05:17 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 14:05:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7dba829be9b12b85e63919ccd7d20656246647fa
Cr-Commit-Position: refs/heads/master@{#26777}

Powered by Google App Engine
This is Rietveld 408576698