Issue 941983003: Hoist cue "deactivation" out of TextTrackCueList::remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 941983003: Hoist cue "deactivation" out of TextTrackCueList::remove (Closed)

Created:
5 years, 10 months ago by fs

Modified:
5 years, 10 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Hoist cue "deactivation" out of TextTrackCueList::remove Hoist the calls to setIsActive and removeDisplayTree into the callers. This brings us closer to avoiding side-effects in fairly low-level code. In TextTrackCueList::updateCueIndex open-code the remove()-call and eliminate the redundant call to contains(). Also eliminate contains() itself because it no longer has any uses. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190574

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	Source/core/html/track/TextTrack.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/html/track/TextTrackCueList.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/track/TextTrackCueList.cpp	View	1 chunk	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941983003/1

5 years, 10 months ago (2015-02-20 16:19:30 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-20 16:23:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190574

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages