Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 941973005: Push cue timeline management out of LoadableTextTrack (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, tyoshino+watch_chromium.org, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Push cue timeline management out of LoadableTextTrack When a LoadableTextTrack receives cues from the loader, it adds them to the cue list and notifies the CueTimeline. This is the only place where this kind of TextTrack state is directly handled by subclasses of TextTrack. Moving this to TextTrack we can "lock down" state - cue list and timeline - some more, and have updates due to list-mutations in a single place (there's currently still updates in HTMLMediaElement though.) This also makes LoadableTextTrack look more like a provider of cues. Transport of cues needs to be updated to use a wider type. Also make use of Vector::swap in VTTParser while changing the signatures. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M Source/core/html/track/LoadableTextTrack.cpp View 2 chunks +2 lines, -13 lines 0 comments Download
M Source/core/html/track/TextTrack.h View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/loader/TextTrackLoader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 10 months ago (2015-02-20 21:39:57 UTC) #2
philipj_slow
lgtm
5 years, 10 months ago (2015-02-23 13:47:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941973005/1
5 years, 10 months ago (2015-02-23 13:48:43 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 13:52:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190657

Powered by Google App Engine
This is Rietveld 408576698