Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 941973004: ResourceResponse: Fix self-assignment in DeepCopy(). (Closed)

Created:
5 years, 10 months ago by Raphael Kubo da Costa (rakuco)
Modified:
5 years, 10 months ago
Reviewers:
mmenke, davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ResourceResponse: Fix self-assignment in DeepCopy(). Fix what looks like a copy-paste error in the assignment of |was_alternate_protocol_available|. Committed: https://crrev.com/b11f5295d455e29e743481cffa93b29baf182bc4 Cr-Commit-Position: refs/heads/master@{#317374}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/resource_response.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Raphael Kubo da Costa (rakuco)
5 years, 10 months ago (2015-02-20 14:53:18 UTC) #2
mmenke
Eeee....LGTM!
5 years, 10 months ago (2015-02-20 14:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941973004/20001
5 years, 10 months ago (2015-02-20 15:00:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/44221)
5 years, 10 months ago (2015-02-20 15:19:07 UTC) #7
davidben
Oof. lgtm.
5 years, 10 months ago (2015-02-20 15:24:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941973004/20001
5 years, 10 months ago (2015-02-20 19:35:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 19:38:41 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:39:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b11f5295d455e29e743481cffa93b29baf182bc4
Cr-Commit-Position: refs/heads/master@{#317374}

Powered by Google App Engine
This is Rietveld 408576698