Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: src/cpu-profiler.h

Issue 941973002: CpuProfiler: eliminate cpu-profiler dependency from heap-inl.h (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/cpu-profiler.h
diff --git a/src/cpu-profiler.h b/src/cpu-profiler.h
index 140de3b906084df41fe9e10d2549bd24195b805e..d8341d823837e69be7a1ec7d697cc22bbfcc81db 100644
--- a/src/cpu-profiler.h
+++ b/src/cpu-profiler.h
@@ -28,7 +28,6 @@ class ProfileGenerator;
V(CODE_MOVE, CodeMoveEventRecord) \
V(CODE_DISABLE_OPT, CodeDisableOptEventRecord) \
V(CODE_DEOPT, CodeDeoptEventRecord) \
- V(SHARED_FUNC_MOVE, SharedFunctionInfoMoveEventRecord) \
V(REPORT_BUILTIN, ReportBuiltinEventRecord)
@@ -52,7 +51,6 @@ class CodeCreateEventRecord : public CodeEventRecord {
Address start;
CodeEntry* entry;
unsigned size;
- Address shared;
INLINE(void UpdateCodeMap(CodeMap* code_map));
};
@@ -86,15 +84,6 @@ class CodeDeoptEventRecord : public CodeEventRecord {
};
-class SharedFunctionInfoMoveEventRecord : public CodeEventRecord {
- public:
- Address from;
- Address to;
-
- INLINE(void UpdateCodeMap(CodeMap* code_map));
-};
-
-
class ReportBuiltinEventRecord : public CodeEventRecord {
public:
Address start;
@@ -251,7 +240,7 @@ class CpuProfiler : public CodeEventListener {
virtual void GetterCallbackEvent(Name* name, Address entry_point);
virtual void RegExpCodeCreateEvent(Code* code, String* source);
virtual void SetterCallbackEvent(Name* name, Address entry_point);
- virtual void SharedFunctionInfoMoveEvent(Address from, Address to);
+ virtual void SharedFunctionInfoMoveEvent(Address from, Address to) {}
INLINE(bool is_profiling() const) { return is_profiling_; }
bool* is_profiling_address() {
« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698