Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 941963003: Revert of [turbofan] Finally get rid of the generic algorithm. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Finally get rid of the generic algorithm. (patchset #2 id:20001 of https://codereview.chromium.org/944803002/) Reason for revert: Breaks dbg builds. Original issue's description: > [turbofan] Finally get rid of the generic algorithm. > > R=svenpanne@chromium.org > > Committed: https://crrev.com/5bbe693e4817011b6a496c638c9f09026fd3dac9 > Cr-Commit-Position: refs/heads/master@{#26760} TBR=svenpanne@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c7810004bb462bdf864f89774132f0fc25b4d9fa Cr-Commit-Position: refs/heads/master@{#26763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -77 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/generic-algorithm.h View 1 chunk +120 lines, -0 lines 0 comments Download
A src/compiler/graph-inl.h View 1 chunk +25 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/compiler/js-inlining.cc View 7 chunks +85 lines, -70 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Finally get rid of the generic algorithm.
5 years, 10 months ago (2015-02-20 09:14:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941963003/1
5 years, 10 months ago (2015-02-20 09:14:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 09:14:45 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 09:14:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7810004bb462bdf864f89774132f0fc25b4d9fa
Cr-Commit-Position: refs/heads/master@{#26763}

Powered by Google App Engine
This is Rietveld 408576698