Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 941953003: Fix ChromiumLinkerTest crashing due to null Context (Closed)

Created:
5 years, 10 months ago by petrcermak
Modified:
5 years, 10 months ago
Reviewers:
Ted C, rmcilroy
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, simonb (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromiumLinkerTest crashing due to null Context This patch fixes an exception thrown while running ChromiumLinkerTest which was caused by null Context. The solution is to make ChromeLinkerTestApplication be a subclass of BaseChromiumApplication because it automatically calls ApplicationStatus.initialize() in onCreate(). BUG=459669 Committed: https://crrev.com/0e657f72853e60d37eb4d1fab5be0fa674028d6b Cr-Commit-Position: refs/heads/master@{#317358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
petrcermak
Hi, please review this small patch. Thanks, Petr
5 years, 10 months ago (2015-02-20 12:11:24 UTC) #2
rmcilroy
On 2015/02/20 12:11:24, petrcermak wrote: > Hi, please review this small patch. > > Thanks, ...
5 years, 10 months ago (2015-02-20 13:34:40 UTC) #3
Ted C
lgtm
5 years, 10 months ago (2015-02-20 17:40:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941953003/1
5 years, 10 months ago (2015-02-20 17:41:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 18:40:09 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 18:41:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e657f72853e60d37eb4d1fab5be0fa674028d6b
Cr-Commit-Position: refs/heads/master@{#317358}

Powered by Google App Engine
This is Rietveld 408576698