Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 941943003: MacViews: Allow the BridgedNativeWidgetTest to focus its textfield (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
Reviewers:
Andre
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Allow the BridgedNativeWidgetTest to focus its textfield Some tests regressed in r316774 because the way edit commands were dispatched in BridgedContentView changed from going directly to the TextInputClient to instead go through the InputMethod. r316774 included a check added to views::Textfield to ensure any scheduled edit command had been processed before scheduling a new one. Some tests failed that check: Because the textfield did not have focus, the dispatch of the event that would commit the edit command was not being received. This CL ensures the textfield requests focus in the test. Fixes (mac-only) views_unittests: BridgedNativeWidgetTest.TextInput_MoveLeftRight BridgedNativeWidgetTest.TextInput_DeleteBackward BridgedNativeWidgetTest.TextInput_DeleteForward BUG=454353 Committed: https://crrev.com/6d2b33248c109d735b041eed2e8229fa0c95d4cf Cr-Commit-Position: refs/heads/master@{#317715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/views/cocoa/bridged_native_widget_unittest.mm View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Andre, please take a look
5 years, 10 months ago (2015-02-23 07:39:46 UTC) #2
Andre
LGTM
5 years, 10 months ago (2015-02-23 18:03:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941943003/1
5 years, 10 months ago (2015-02-24 00:19:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 01:10:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:10:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d2b33248c109d735b041eed2e8229fa0c95d4cf
Cr-Commit-Position: refs/heads/master@{#317715}

Powered by Google App Engine
This is Rietveld 408576698