win vs2015: fix variable shadowing warnings in net/quic

win vs2015: fix variable shadowing warnings in net/quic

d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(198): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\cert_compressor.cc(189): note: see declaration of 'i'

d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(668): warning C4456: declaration of 'client_hello_serialized' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(652): note: see declaration of 'client_hello_serialized'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1336): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1292): note: see declaration of 'i'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1481): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1493): warning C4457: declaration of 'token' hides function parameter
d:\src\cr2\src\net\quic\crypto\quic_crypto_server_config.cc(1472): note: see declaration of 'token'

d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\crypto\strike_register.cc(498): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(453): note: see declaration of 'i'
c:\program files (x86)\microsoft visual studio 14.0\vc\include\utility(151): note: while compiling class template member function 'std::pair<uint32,uint32>::pair<uint32,uint32,void>(std::pair<uint32,uint32> &&) noexcept'
d:\src\cr2\src\net\quic\crypto\strike_register.cc(502): warning C4456: declaration of 'bit' hides previous local declaration
d:\src\cr2\src\net\quic\crypto\strike_register.cc(454): note: see declaration of 'bit'
ninja: build stopped: subcommand failed.

d:\src\cr2\src\net\quic\quic_framer.cc(1350): error C2220: warning treated as error - no 'object' file generated
d:\src\cr2\src\net\quic\quic_framer.cc(1350): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(1338): note: see declaration of 'i'
d:\src\cr2\src\net\quic\quic_framer.cc(2102): warning C4456: declaration of 'time_delta_us' hides previous local declaration
d:\src\cr2\src\net\quic\quic_framer.cc(2080): note: see declaration of 'time_delta_us'
ninja: build stopped: subcommand failed.

BUG=440500
R=rtenneti@chromium.org

Committed: https://crrev.com/356a110050a17a19bf9168fadc0a1acb828c582b
Cr-Commit-Position: refs/heads/master@{#317370}

[ramant (doing other things), 2015-02-20 18:15:25]

lgtm

[scottmg, 2015-02-20 19:20:39]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-02-20 19:21:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941933002/1

[commit-bot: I haz the power, 2015-02-20 19:29:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-20 19:30:37]

Patchset 1 (id:??) landed as
https://crrev.com/356a110050a17a19bf9168fadc0a1acb828c582b
Cr-Commit-Position: refs/heads/master@{#317370}

[ramant (doing other things), 2015-02-20 20:04:07]

https://codereview.chromium.org/941933002/diff/1/net/quic/crypto/strike_regis...
File net/quic/crypto/strike_register.cc (right):

https://codereview.chromium.org/941933002/diff/1/net/quic/crypto/strike_regis...
net/quic/crypto/strike_register.cc:502: bit = j->first % 8;
IMO, we should define a "unsigned bit_new = ..." and use that. We shouldn't
modify the original bit. Sorry to have missed that (to keep the logic same as
before).

Will fix it in the next cl. This code is not used in chromium's clise side code.

[scottmg, 2015-02-20 20:30:51]

https://codereview.chromium.org/941933002/diff/1/net/quic/crypto/strike_regis...
File net/quic/crypto/strike_register.cc (right):

https://codereview.chromium.org/941933002/diff/1/net/quic/crypto/strike_regis...
net/quic/crypto/strike_register.cc:502: bit = j->first % 8;
On 2015/02/20 20:04:07, ramant wrote:
> IMO, we should define a "unsigned bit_new = ..." and use that. We shouldn't
> modify the original bit. Sorry to have missed that (to keep the logic same as
> before).
> 
> Will fix it in the next cl. This code is not used in chromium's clise side
code.

Shoot, I didn't notice it might be used in the else arm without going here
first. Fix here: https://codereview.chromium.org/946003003