Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 941913002: Remove two more uses of NodeList (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove two more uses of NodeList We now use List<Node> instead, which is more idiomatic. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/57a970f9f909a78e1df0674513d65556f4cf42ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M sky/engine/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/Text.idl View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M sky/engine/core/html/HTMLContentElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-20 03:05:24 UTC) #1
ojan
lgtm
5 years, 10 months ago (2015-02-20 03:44:13 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-20 05:10:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
57a970f9f909a78e1df0674513d65556f4cf42ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698