Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 941893002: Revert of Add more targets to "gn check" (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more targets to "gn check" (patchset #3 id:40001 of https://codereview.chromium.org/940613002/) Reason for revert: This broken win8 gn bots because of an illegal include. ERROR at //device/usb/usb_service_impl.cc:21:11: Include not allowed. #include "device/core/device_monitor_win.h" e.g. https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4896/steps/gn%20check/logs/stdio Original issue's description: > Add more targets to "gn check" > > R=dpranke > TBR=armansito@chromium.org (bluetooth) > > Committed: https://crrev.com/8cac5f9d9c3847657b57783d30f861adb6c29cac > Cr-Commit-Position: refs/heads/master@{#317160} TBR=dpranke@chromium.org,armansito@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/28274b27a18a29c8a5d3bdda150f3c47e6a28584 Cr-Commit-Position: refs/heads/master@{#317204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -40 lines) Patch
M .gn View 1 chunk +0 lines, -6 lines 0 comments Download
M dbus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M device/core/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M device/hid/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M device/media_transfer_protocol/BUILD.gn View 1 chunk +2 lines, -8 lines 0 comments Download
M device/serial/BUILD.gn View 1 chunk +1 line, -7 lines 0 comments Download
M device/usb/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M device/vibration/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
Created Revert of Add more targets to "gn check"
5 years, 10 months ago (2015-02-20 01:05:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941893002/1
5 years, 10 months ago (2015-02-20 01:06:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 01:07:37 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 01:08:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28274b27a18a29c8a5d3bdda150f3c47e6a28584
Cr-Commit-Position: refs/heads/master@{#317204}

Powered by Google App Engine
This is Rietveld 408576698