Add more size_t -> int warning fixes for the win x64 GN build.

Add more size_t -> int warning fixes for the win x64 GN build.

R=brettw@chromium.org
BUG=354261
Committed: https://crrev.com/8ec93a3ac28c857ae106a2c1929cc935ab76ec03
Cr-Commit-Position: refs/heads/master@{#317439}

[Dirk Pranke, 2015-02-20 00:37:49]

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
File third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn:32: configs = [
"//build/config/compiler:no_size_t_to_int_warning" ]
I think this change actually needs to be made in the mojo repo and then rolled
into here, so assume I will take care of that.

[jamesr, 2015-02-20 00:44:11]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2015-02-20 00:44:11]

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
File third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn:32: configs = [
"//build/config/compiler:no_size_t_to_int_warning" ]
On 2015/02/20 00:37:49, Dirk Pranke wrote:
> I think this change actually needs to be made in the mojo repo and then rolled
> into here, so assume I will take care of that.

Since this is //third_party is this warning enabled to begin with?  this file is
maintained in the mojo repo and we try to keep the deps down to a minimum

[Dirk Pranke, 2015-02-20 00:52:54]

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
File third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn:32: configs = [
"//build/config/compiler:no_size_t_to_int_warning" ]
On 2015/02/20 00:44:11, jamesr wrote:
> On 2015/02/20 00:37:49, Dirk Pranke wrote:
> > I think this change actually needs to be made in the mojo repo and then
rolled
> > into here, so assume I will take care of that.
> 
> Since this is //third_party is this warning enabled to begin with?  this file
is
> maintained in the mojo repo and we try to keep the deps down to a minimum

You will get this warning by default on win x64. You can either use this config
or the no_chromium_code config to disable it, but it doesn't look like you're
picking up the no_chromium_code config from anything.

Alternatively, we can fix the warnings ;). I will take a look and see how
feasible that is for me to do.

[jamesr, 2015-02-20 00:53:52]

I didn't think we set chromium code for //third_party/ stuff.

What's the warning?

[Dirk Pranke, 2015-02-20 00:58:20]

On 2015/02/20 00:53:52, jamesr wrote:
> I didn't think we set chromium code for //third_party/ stuff.

chromium_code is set by default for all targets, so you have to explicitly
remove it and add "no_chromium_code" in third_party targets where needed.

> What's the warning?

https://msdn.microsoft.com/en-us/library/6kck0s93.aspx

which is disabled if we pass the /Wd4267 flag, which either of those configs
will do.

[Dirk Pranke, 2015-02-20 01:26:20]

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
File third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn (right):

https://codereview.chromium.org/941863002/diff/1/third_party/mojo/src/mojo/pu...
third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn:32: configs = [
"//build/config/compiler:no_size_t_to_int_warning" ]
To close this comment out ... fixing the warnings is easy, so I'll post a patch
for that to mojo and things'll be fixed once that lands (w/ the next mojo roll).

[brettw, 2015-02-20 22:47:56]

lgtm

[Dirk Pranke, 2015-02-20 22:51:49]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2015-02-20 22:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941863002/20001

[commit-bot: I haz the power, 2015-02-20 23:36:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-20 23:37:00]

Patchset 2 (id:??) landed as
https://crrev.com/8ec93a3ac28c857ae106a2c1929cc935ab76ec03
Cr-Commit-Position: refs/heads/master@{#317439}