Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 941843002: Suppress smooth scroll for trackpad scrolls on Mac. (Closed)

Created:
5 years, 10 months ago by skobes
Modified:
5 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dstockwell, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Suppress smooth scroll for trackpad scrolls on Mac. Smooth scrolling doesn't make sense when the event is marked as having precise scrolling deltas. This change tells ScrollAnimatorMac to skip smooth scrolls in this case even if smooth scrolling is otherwise enabled. There is already similar code in ScrollAnimatorNone for other platforms. ScrollAnimatorMac now smooth-scrolls only for line/page/document granularity (e.g., keyboard-triggered scrolls). It was disabled for wheel scrolls in http://trac.webkit.org/changeset/73683. BUG=575, 459739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
skobes
5 years, 10 months ago (2015-02-20 00:01:07 UTC) #2
ajuma
lgtm
5 years, 10 months ago (2015-02-20 00:29:23 UTC) #3
Julien - ping for review
platform/ lgtm
5 years, 10 months ago (2015-02-20 22:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941843002/1
5 years, 10 months ago (2015-02-20 22:29:17 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 22:35:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190597

Powered by Google App Engine
This is Rietveld 408576698