chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java - Issue 941823002: [App banners] Add server-controlled experiment to disable app banners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 941823002: [App banners] Add server-controlled experiment to disable app banners (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add flag BACK to about:flags, use it to disable half of the feature Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java ('k') | chrome/browser/android/banners/app_banner_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

index 2e9c2c388336b064f8f00627b5e202cba5e639e3..66a66f21248a94150c7f06fae5ae720c159ef0a5 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

@@ -11,7 +11,9 @@ import android.view.View;

import android.widget.TextView;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.Feature;

+import org.chromium.chrome.ChromeSwitches;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.Tab;

import org.chromium.chrome.browser.infobar.AnimationHelper;

@@ -131,6 +133,7 @@ public class AppBannerManagerTest extends ChromeShellTestBase {

});

}

+ @CommandLineFlags.Add(ChromeSwitches.ENABLE_APP_INSTALL_ALERTS)

@SmallTest

@Feature({"AppBanners"})

public void testBannerAppears() throws Exception {

@@ -148,6 +151,7 @@ public class AppBannerManagerTest extends ChromeShellTestBase {

assertTrue(waitUntilAppBannerInfoBarAppears());

}

+ @CommandLineFlags.Add(ChromeSwitches.ENABLE_APP_INSTALL_ALERTS)

@MediumTest

@Feature({"AppBanners"})

public void testBannerAppearsThenDoesNotAppearAgainForMonths() throws Exception {

@@ -198,6 +202,7 @@ public class AppBannerManagerTest extends ChromeShellTestBase {

assertTrue(waitUntilAppBannerInfoBarAppears());

}

+ @CommandLineFlags.Add(ChromeSwitches.ENABLE_APP_INSTALL_ALERTS)

@MediumTest

@Feature({"AppBanners"})

public void testBlockedBannerDoesNotAppearAgainForMonths() throws Exception {

@@ -255,6 +260,7 @@ public class AppBannerManagerTest extends ChromeShellTestBase {

assertTrue(waitUntilAppBannerInfoBarAppears());

}

+ @CommandLineFlags.Add(ChromeSwitches.ENABLE_APP_INSTALL_ALERTS)

@MediumTest

@Feature({"AppBanners"})

public void testBitmapFetchersCanOverlapWithoutCrashing() throws Exception {