Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 941773002: Revert of Clean up perftesthelper.js style (Closed)

Created:
5 years, 10 months ago by epenner
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@+newCSSValueTypePerfTests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up perftesthelper.js style (patchset #2 id:20001 of https://codereview.chromium.org/927583005/) Reason for revert: Tough animation cases are failing due to a few missed files in the refactor. Original issue's description: > Clean up perftesthelper.js style > > This change makes tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js > consistent with the Chromium Javascript style guide: > - Fixed indentation > - Added missing semicolon > - Renamed file to be underscore separated > > Committed: https://crrev.com/30a1e4bc96550502e8607ac0f0a246eb42a61852 > Cr-Commit-Position: refs/heads/master@{#316965} TBR=qyearsley@chromium.org,alancutter@google.com,alancutter@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c836bb3510711b7866e55e17910ba01db37ab402 Cr-Commit-Position: refs/heads/master@{#317092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -104 lines) Patch
M tools/perf/page_sets/tough_animation_cases/balls_css_keyframe_animations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_keyframe_animations_composited_transform.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_2_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_40_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_css_transition_all_properties.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_javascript_canvas.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_javascript_css.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/balls_svg_animations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_many_keyframes.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_simultaneous_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_chaining_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_infinite_iterations.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_animations_staggered_triggering_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_new_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_style_element.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_class.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_inline_style.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_color.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_filter.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_3d.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_complex.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_length_simple.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_transform_complex.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/css_value_type_transform_simple.html View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/tough_animation_cases/overlay_background_color_css_transitions.html View 1 chunk +1 line, -1 line 0 comments Download
D tools/perf/page_sets/tough_animation_cases/resources/perf_test_helper.js View 1 chunk +0 lines, -61 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epenner
Created Revert of Clean up perftesthelper.js style
5 years, 10 months ago (2015-02-19 19:11:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941773002/1
5 years, 10 months ago (2015-02-19 19:12:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 19:14:56 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:16:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c836bb3510711b7866e55e17910ba01db37ab402
Cr-Commit-Position: refs/heads/master@{#317092}

Powered by Google App Engine
This is Rietveld 408576698