Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 941763002: Preserve required MS x64 call stack alignment when flushing registers. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Preserve required MS x64 call stack alignment when flushing registers. The Microsoft x64 calling convention also requires a 16-byte stack alignment on invocation of "call"; adjust pushAllRegisters stack usage accordingly. ( From patch contributed by ilya.berdichevsky ) R=haraken BUG=446479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/platform/heap/asm/SaveRegisters_x86.asm View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. A latent issue, for now.
5 years, 10 months ago (2015-02-19 19:14:14 UTC) #2
haraken
rubberstamp LGTM (I'm not familiar with asm :-)
5 years, 10 months ago (2015-02-19 23:12:21 UTC) #3
sof
On 2015/02/19 23:12:21, haraken wrote: > rubberstamp LGTM (I'm not familiar with asm :-) I ...
5 years, 10 months ago (2015-02-20 06:30:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941763002/1
5 years, 10 months ago (2015-02-20 06:31:19 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 07:52:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190539

Powered by Google App Engine
This is Rietveld 408576698