Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isherman comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 011474fedca1a1ea5efd9c9270aa75566d58071c..79b2a8c7b8fa271574123661e631b546fc882708 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -3526,15 +3526,6 @@ int SSLClientSocketNSS::DoVerifyCertComplete(int result) {
// purposes. See https://bugzilla.mozilla.org/show_bug.cgi?id=508081 and
// http://crbug.com/15630 for more info.
- // TODO(hclam): Skip logging if server cert was expected to be bad because
- // |server_cert_verify_result_| doesn't contain all the information about
- // the cert.
- if (result == OK) {
- int ssl_version =
- SSLConnectionStatusToVersion(core_->state().ssl_connection_status);
- RecordConnectionTypeMetrics(ssl_version);
- }
-
const CertStatus cert_status = server_cert_verify_result_.cert_status;
if (transport_security_state_ &&
(result == OK ||

Powered by Google App Engine
This is Rietveld 408576698