Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Carve some corners into the round hole so the square peg fits better Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index c6752d4761db2f47b34c96f4d72c30089632caba..be752497bce1fc5a799e4729ac70d46063b92d6b 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -1211,8 +1211,6 @@ int SSLClientSocketOpenSSL::DoVerifyCertComplete(int result) {
}
if (result == OK) {
- RecordConnectionTypeMetrics(GetNetSSLVersion(ssl_));
-
if (SSL_session_reused(ssl_)) {
// Record whether or not the server tried to resume a session for a
// different version. See https://crbug.com/441456.

Powered by Google App Engine
This is Rietveld 408576698