Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: net/socket/ssl_client_socket_pool.cc

Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isherman comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/socket/ssl_client_socket_pool.h" 5 #include "net/socket/ssl_client_socket_pool.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/metrics/field_trial.h" 9 #include "base/metrics/field_trial.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 494
495 UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_2", 495 UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_2",
496 connect_duration, 496 connect_duration,
497 base::TimeDelta::FromMilliseconds(1), 497 base::TimeDelta::FromMilliseconds(1),
498 base::TimeDelta::FromMinutes(1), 498 base::TimeDelta::FromMinutes(1),
499 100); 499 100);
500 500
501 SSLInfo ssl_info; 501 SSLInfo ssl_info;
502 ssl_socket_->GetSSLInfo(&ssl_info); 502 ssl_socket_->GetSSLInfo(&ssl_info);
503 503
504 UMA_HISTOGRAM_ENUMERATION("Net.SSLVersion", SSLConnectionStatusToVersion(
505 ssl_info.connection_status),
506 SSL_CONNECTION_VERSION_MAX);
507
504 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSL_CipherSuite", 508 UMA_HISTOGRAM_SPARSE_SLOWLY("Net.SSL_CipherSuite",
505 SSLConnectionStatusToCipherSuite( 509 SSLConnectionStatusToCipherSuite(
506 ssl_info.connection_status)); 510 ssl_info.connection_status));
507 511
508 UMA_HISTOGRAM_BOOLEAN( 512 UMA_HISTOGRAM_BOOLEAN(
509 "Net.RenegotiationExtensionSupported", 513 "Net.RenegotiationExtensionSupported",
510 (ssl_info.connection_status & 514 (ssl_info.connection_status &
511 SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION) == 0); 515 SSL_CONNECTION_NO_RENEGOTIATION_EXTENSION) == 0);
512 516
513 if (ssl_info.handshake_type == SSLInfo::HANDSHAKE_RESUME) { 517 if (ssl_info.handshake_type == SSLInfo::HANDSHAKE_RESUME) {
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 CHECK(it != messenger_map_.end()); 852 CHECK(it != messenger_map_.end());
849 delete it->second; 853 delete it->second;
850 messenger_map_.erase(it); 854 messenger_map_.erase(it);
851 } 855 }
852 856
853 void SSLClientSocketPool::OnSSLConfigChanged() { 857 void SSLClientSocketPool::OnSSLConfigChanged() {
854 FlushWithError(ERR_NETWORK_CHANGED); 858 FlushWithError(ERR_NETWORK_CHANGED);
855 } 859 }
856 860
857 } // namespace net 861 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698