Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: net/socket/ssl_client_socket.h

Issue 941743002: Add a dedicated SSL protocol version metric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Carve some corners into the round hole so the square peg fits better Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket.cc » ('j') | net/socket/ssl_client_socket_pool.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_ 5 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_
6 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_ 6 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 bool stapled_ocsp_response_received); 194 bool stapled_ocsp_response_received);
195 195
196 // Records histograms for channel id support during full handshakes - resumed 196 // Records histograms for channel id support during full handshakes - resumed
197 // handshakes are ignored. 197 // handshakes are ignored.
198 static void RecordChannelIDSupport( 198 static void RecordChannelIDSupport(
199 ChannelIDService* channel_id_service, 199 ChannelIDService* channel_id_service,
200 bool negotiated_channel_id, 200 bool negotiated_channel_id,
201 bool channel_id_enabled, 201 bool channel_id_enabled,
202 bool supports_ecc); 202 bool supports_ecc);
203 203
204 // Records ConnectionType histograms for a successful SSL connection.
205 static void RecordConnectionTypeMetrics(int ssl_version);
206
207 // Returns whether TLS channel ID is enabled. 204 // Returns whether TLS channel ID is enabled.
208 static bool IsChannelIDEnabled( 205 static bool IsChannelIDEnabled(
209 const SSLConfig& ssl_config, 206 const SSLConfig& ssl_config,
210 ChannelIDService* channel_id_service); 207 ChannelIDService* channel_id_service);
211 208
212 // Determine if there is at least one enabled cipher suite that satisfies 209 // Determine if there is at least one enabled cipher suite that satisfies
213 // Section 9.2 of the HTTP/2 specification. Note that the server might still 210 // Section 9.2 of the HTTP/2 specification. Note that the server might still
214 // pick an inadequate cipher suite. 211 // pick an inadequate cipher suite.
215 static bool HasCipherAdequateForHTTP2( 212 static bool HasCipherAdequateForHTTP2(
216 const std::vector<uint16>& cipher_suites); 213 const std::vector<uint16>& cipher_suites);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 bool signed_cert_timestamps_received_; 255 bool signed_cert_timestamps_received_;
259 // True if a stapled OCSP response was received. 256 // True if a stapled OCSP response was received.
260 bool stapled_ocsp_response_received_; 257 bool stapled_ocsp_response_received_;
261 // Protocol negotiation extension used. 258 // Protocol negotiation extension used.
262 SSLNegotiationExtension negotiation_extension_; 259 SSLNegotiationExtension negotiation_extension_;
263 }; 260 };
264 261
265 } // namespace net 262 } // namespace net
266 263
267 #endif // NET_SOCKET_SSL_CLIENT_SOCKET_H_ 264 #endif // NET_SOCKET_SSL_CLIENT_SOCKET_H_
OLDNEW
« no previous file with comments | « no previous file | net/socket/ssl_client_socket.cc » ('j') | net/socket/ssl_client_socket_pool.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698