Chromium Code Reviews Chromium Code Reviews
Issue 941743002:
Add a dedicated SSL protocol version metric. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index bce02858fd55fc9c939193d3659665cc0ac299a1..e21c08fa0554f2e5f41541984fc0e30b46e99570 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -16266,7 +16266,7 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Net.ConnectionTypeCount3" enum="ConnectionType"> |
| - <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| + <owner>davidben@chromium.org</owner> |
| <summary> |
| Each bucket is the number of successful connections of a particular type |
| that the user has had during the session. |
| @@ -17261,7 +17261,7 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </histogram> |
| <histogram name="Net.HadConnectionType3" enum="ConnectionType"> |
| - <owner>Please list the metric's owners. Add more owner tags as needed.</owner> |
| + <owner>davidben@chromium.org</owner> |
| <summary> |
| Each bucket is a boolean (0 or 1) indicating whether the user has had a |
| successful connection of that type during the session. |
| @@ -19721,6 +19721,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Net.SSL_Version" enum="SSLVersion"> |
| + <owner>davidben@chromium.org</owner> |
| + <summary>The SSL/TLS version that was negotiated.</summary> |
| +</histogram> |
| + |
| <histogram name="Net.SSLCertBlacklisted"> |
| <owner>agl@chromium.org</owner> |
| <summary> |
| @@ -58523,6 +58528,17 @@ To add a new entry, add it with any value and run test to compute valid value. |
| label="Displayed clock interstitial. (DISPLAYED_CLOCK_INTERSTITIAL)"/> |
| </enum> |
| +<enum name="SSLVersion" type="int"> |
| + <summary>SSL/TLS protocol versions</summary> |
| + <int value="0">Unknown</int> |
| + <int value="1">SSL 2.0</int> |
| + <int value="2">SSL 3.0</int> |
| + <int value="3">TLS 1.0</int> |
| + <int value="4">TLS 1.1</int> |
| + <int value="5">TLS 1.2</int> |
| + <int value="7">QUIC</int> |
|
Ryan Sleevi
2015/02/19 18:40:48
Why QUIC? That's not an SSL version.
davidben
2015/02/19 19:09:10
The enum includes an entry for QUIC, so I figured
|
| +</enum> |
| + |
| <enum name="StartupURLsMigration" type="int"> |
| <int value="0" label="Performed migration"/> |
| <int value="1" label="No migration value"/> |
