Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 941733002: [Android] Hide partner bookmark node if it's deleted. (Closed)

Created:
5 years, 10 months ago by Kibeom Kim (inactive)
Modified:
5 years, 10 months ago
Reviewers:
Ted C, Ian Wen, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Hide partner bookmark node if it's deleted. In enhanced bookmark UI, we still showed the partner bookmark node in the side drawer even if it's deleted. BUG=460122 Committed: https://crrev.com/659e4cc942f8ac94d2a5bb3505c6bbbc7fada463 Cr-Commit-Position: refs/heads/master@{#317102}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Kibeom Kim (inactive)
5 years, 10 months ago (2015-02-19 17:03:16 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-02-19 17:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941733002/1
5 years, 10 months ago (2015-02-19 18:26:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/60928)
5 years, 10 months ago (2015-02-19 18:36:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941733002/1
5 years, 10 months ago (2015-02-19 18:51:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/44288)
5 years, 10 months ago (2015-02-19 19:02:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941733002/20001
5 years, 10 months ago (2015-02-19 19:07:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 19:31:52 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:32:29 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/659e4cc942f8ac94d2a5bb3505c6bbbc7fada463
Cr-Commit-Position: refs/heads/master@{#317102}

Powered by Google App Engine
This is Rietveld 408576698