Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 941713002: [WebView] Tests for visual state during fullscreen transitions. (Closed)

Created:
5 years, 10 months ago by Ignacio Solla
Modified:
5 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Tobias Sargeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@breakSwapIfNoUpdates
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Tests for visual state during fullscreen transitions. We add tests that verify that VisualStateCallbacks are delivered correctly during fullscreen transitions. BUG=459044 Committed: https://crrev.com/09dd483ed39867502d9e036e511d118da36b13eb Cr-Commit-Position: refs/heads/master@{#317077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -0 lines) Patch
M android_webview/android_webview_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java View 3 chunks +156 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/GraphicsTestUtils.java View 2 chunks +15 lines, -0 lines 0 comments Download
A android_webview/test/shell/assets/visual_state_during_fullscreen_test.html View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ignacio Solla
5 years, 10 months ago (2015-02-19 15:23:53 UTC) #2
boliu
lgtm
5 years, 10 months ago (2015-02-19 17:04:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941713002/1
5 years, 10 months ago (2015-02-19 17:55:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 18:14:20 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 18:14:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/09dd483ed39867502d9e036e511d118da36b13eb
Cr-Commit-Position: refs/heads/master@{#317077}

Powered by Google App Engine
This is Rietveld 408576698