Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 941683002: Removing prefixMatch attribute of CacheQueryOptions- Chromium Side (Closed)

Created:
5 years, 10 months ago by Paritosh Kumar
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing prefixMatch attribute of CacheQueryOptions. As get removed in latest specs, removing it. spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-query-options-dictionary PATCH 1: Chromium: [THIS PATCH] PATCH 2: Blink: https://codereview.chromium.org/927723003/ BUG=462837 Committed: https://crrev.com/91784b8a7800d1a09c10d89c2b4e424fae0c5383 Cr-Commit-Position: refs/heads/master@{#318842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M content/common/service_worker/service_worker_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Paritosh Kumar
Please have a look.
5 years, 10 months ago (2015-02-20 04:41:34 UTC) #2
Paritosh Kumar
Please have a look.
5 years, 10 months ago (2015-02-27 09:36:05 UTC) #4
jsbell
lgtm as non-owner
5 years, 9 months ago (2015-02-27 16:44:25 UTC) #5
horo
lgtm
5 years, 9 months ago (2015-03-02 02:28:59 UTC) #6
Paritosh Kumar
@mike: Please have a look.
5 years, 9 months ago (2015-03-02 13:23:37 UTC) #8
Mike West
On 2015/03/02 at 13:23:37, paritosh.in wrote: > @mike: Please have a look. IPC LGTM
5 years, 9 months ago (2015-03-02 14:45:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941683002/1
5 years, 9 months ago (2015-03-03 04:01:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 05:35:02 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 05:35:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91784b8a7800d1a09c10d89c2b4e424fae0c5383
Cr-Commit-Position: refs/heads/master@{#318842}

Powered by Google App Engine
This is Rietveld 408576698