Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 941633003: Remove unnessary usage of Tab.getNativePtr(). (Closed)

Created:
5 years, 10 months ago by Yaron
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnessary usage of Tab.getNativePtr(). We shouldn't be asking for native pointers from java. All that was needed was a WebContents, so use that directly. getNativePtr isn't called anymore but can't be removed until the downstream override is gone which needs this patch to roll down. Committed: https://crrev.com/4846e390ad4a0462057dd072fafeea41ea9e5bc6 Cr-Commit-Position: refs/heads/master@{#317089}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yaron
5 years, 10 months ago (2015-02-19 18:05:47 UTC) #2
gone
lgtm
5 years, 10 months ago (2015-02-19 18:07:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941633003/1
5 years, 10 months ago (2015-02-19 18:10:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-19 18:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941633003/20001
5 years, 10 months ago (2015-02-19 18:47:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 19:12:18 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 19:13:18 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4846e390ad4a0462057dd072fafeea41ea9e5bc6
Cr-Commit-Position: refs/heads/master@{#317089}

Powered by Google App Engine
This is Rietveld 408576698