Issue 941633002: Add regression test for CL 897113003

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 941633002: Add regression test for CL 897113003 (Closed)

Created:
5 years, 10 months ago by bartfab (slow)

Modified:
5 years, 10 months ago

Reviewers:
pneubeck (no reviews)

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@h_1_455504_fix_crash

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add regression test for CL 897113003 This CL adds a regression test for CL 897113003, ensuring that consumers are notified that the device-global invalidation service is no longer to be used before it gets destroyed. BUG=455504 TEST=New unit test Committed: https://crrev.com/e6141ebbe66ee641c92a1c97174dcb713687ec9d Cr-Commit-Position: refs/heads/master@{#317075}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941633002/1

5 years, 10 months ago (2015-02-19 17:48:51 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-19 18:07:00 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e6141ebbe66ee641c92a1c97174dcb713687ec9d
Cr-Commit-Position: refs/heads/master@{#317075}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages