Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 941603002: This is followup of 449919 for addressing nit. (Closed)

Created:
5 years, 10 months ago by Deepak
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming a variable and add comments to clarify its usage. BUG=459890 Committed: https://crrev.com/b3a4e8f7ba5c82f8b36c7dfd28f6545605abfa69 Cr-Commit-Position: refs/heads/master@{#317243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/renderer_context_menu/render_view_context_menu_base.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
This is followup for addressing nit. PTAL Thanks
5 years, 10 months ago (2015-02-19 07:33:10 UTC) #2
Avi (use Gerrit)
On 2015/02/19 07:33:10, Deepak wrote: > This is followup for addressing nit. > PTAL > ...
5 years, 10 months ago (2015-02-19 15:29:40 UTC) #3
Deepak
On 2015/02/19 15:29:40, Avi wrote: > On 2015/02/19 07:33:10, Deepak wrote: > > This is ...
5 years, 10 months ago (2015-02-19 15:51:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941603002/1
5 years, 10 months ago (2015-02-20 03:34:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 04:36:30 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 04:37:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3a4e8f7ba5c82f8b36c7dfd28f6545605abfa69
Cr-Commit-Position: refs/heads/master@{#317243}

Powered by Google App Engine
This is Rietveld 408576698