Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 941573004: Revert of Roll libyuv d204db6...194f740 (r1172..1285) (Closed)

Created:
5 years, 10 months ago by magjed_chromium
Modified:
5 years, 10 months ago
Reviewers:
fbarchard
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll libyuv d204db6...194f740 (r1172..1285) (patchset #1 id:1 of https://codereview.chromium.org/943513002/) Reason for revert: Failing Windows DrMemory memory test: content Error report: 07:13:11 drmemory_analyze.py [INFO] Found 1 error reports 07:13:11 drmemory_analyze.py [INFO] Report #1 ### BEGIN MEMORY TOOL REPORT (error hash=#FBECECDC73272255#) UNINITIALIZED READ: reading 0x001ff960-0x001ff980 32 byte(s) within 0x001ff960-0x001ff980 # 0 content.dll!CopyRow_AVX [third_party\libyuv\source\row_win.cc:2687] # 1 content.dll!CopyRow_Any_AVX [third_party\libyuv\source\row_any.cc:672] # 2 content.dll!CopyPlane [third_party\libyuv\source\planar_functions.cc:72] # 3 content.dll!I420Copy [third_party\libyuv\source\convert.cc:90] # 4 content.dll!I420Rotate [third_party\libyuv\source\rotate.cc:1193] # 5 content.dll!ConvertToI420 [third_party\libyuv\source\convert_to_i420.cc:241] # 6 content.dll!content::VideoCaptureController::VideoCaptureDeviceClient::OnIncomingCapturedData [content\browser\renderer_host\media\video_capture_controller.cc:514] # 7 content::VideoCaptureControllerTest_DataCaptureInEachVideoFormatInSequence_Test::TestBody [content\browser\renderer_host\media\video_capture_controller_unittest.cc:661] # 8 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2420] Note: @0:05:20.487 in thread 3640 Note: instruction: vmovdqu (%eax) -> %ymm0 Original issue's description: > Roll libyuv d204db6...194f740 (r1172..1285) > > This roll is primarily done to pick up ValidateJpeg performance improvement. > > TBR=fbarchard > > Committed: https://crrev.com/50bf61b785adf9366446bc26c09e691a1c0db15f > Cr-Commit-Position: refs/heads/master@{#317304} TBR=fbarchard@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f8b1ae7eee5335a4982d9bc2125380d817f022d1 Cr-Commit-Position: refs/heads/master@{#317325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
magjed_chromium
Created Revert of Roll libyuv d204db6...194f740 (r1172..1285)
5 years, 10 months ago (2015-02-20 15:30:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941573004/1
5 years, 10 months ago (2015-02-20 15:32:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 15:33:48 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 15:34:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8b1ae7eee5335a4982d9bc2125380d817f022d1
Cr-Commit-Position: refs/heads/master@{#317325}

Powered by Google App Engine
This is Rietveld 408576698